UI: Keyboard label shortcut #5122
Conversation
|
Toggle show/hide keyboard short keys are working with "F", but the action for a specific keyboard event isn't working now. |
|
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
…cloudstack into keyboard-label-shortcut
…cloudstack into keyboard-label-shortcut
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
sure, thanks @borisstoyanov |
|
@apurv-1 can you look at the conflicts, please? |
|
@davidjumani @borisstoyanov @apurv-1 moving this from milestone 4.18.0.0 to unplanned |
|
@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Codecov Report
@@ Coverage Diff @@
## main #5122 +/- ##
==========================================
Coverage 12.69% 12.69%
- Complexity 8664 8674 +10
==========================================
Files 2718 2729 +11
Lines 256362 256579 +217
Branches 39967 39987 +20
==========================================
+ Hits 32538 32575 +37
- Misses 219686 219859 +173
- Partials 4138 4145 +7 see 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@apurv-1 PR doesn't work as yet. Needs some more fixes. Testing changes |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
Converting this to draft for now as it needs changes to cleanup unused code and deduplicate short keys |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
Thanks for the PR - given the issues around incompatibilities of the keyboard/shortcuts library with Vue3 and antd, this PR would have to be redone. We can explore this in future. Thanks to the GSoC student and all those involved. |
|
@rohityadavcloud opened up #8250, it works with Vue3. Also, we can revamp the designs. |
@apurv-1 will you also port the other keys then 'r' to that new PR? |
|
@DaanHoogland Yes, I have suggested one more thing on that PR. |
11 participants
Description
fixes #4798
Types of changes
Screenshots (if appropriate):
Dashboard.-.CloudStack.-.Google.Chrome.2021-08-31.18-07-03.mp4